Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

feat(endpoint): Support wp76xx based platforms #719

Closed
wants to merge 1 commit into from

Conversation

splasky
Copy link
Contributor

@splasky splasky commented Jul 16, 2020

This commit implement the WP76xx platform for the endpoint.

Close #718

@splasky
Copy link
Contributor Author

splasky commented Jul 16, 2020

Related #707

Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before real implementation, we need the analysis for WP76xx enablement including the policy for maximize the reusable code. Update in #718 and then go back to this pull request.

@splasky splasky marked this pull request as draft July 16, 2020 09:00
@jserv jserv changed the title feat(endpoint): Port endpoint onto WP76xx platform feat(endpoint): Support wp76xx based platforms Jul 27, 2020
Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid copying from Sierra? That is, file "endpoint/endpointComp/interfaces.h"

@splasky splasky force-pushed the WP76test branch 8 times, most recently from 22c46d4 to 684ccef Compare July 29, 2020 15:27
@@ -49,7 +49,12 @@ LEGATO_FLAGS += -DEP_TARGET=$(EP_TARGET)
LEGATO_FLAGS := $(foreach flags, $(LEGATO_FLAGS), -C $(flags))

# Include the build command from the specific target
include endpoint/platform/$(EP_TARGET)/build.mk
ifeq ($(EP_TARGET), simulator)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the commands with

include endpoint/platform/$(EP_TARGET)/build.mk

Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are going to replace HAL, you MUST explain and describe the transition. And even send another pull request(s).


static status_t simulator_get_key(uint8_t *key) {
status_t get_device_key(uint8_t *key) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid exposing too many symbols.

@splasky splasky marked this pull request as ready for review July 30, 2020 12:13
This commit implement the WP76xx platform for the endpoint.

[WIP] Connect success, Try to deploy on buildkite.

Close DLTcollab#718
Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new pull request and corresponding issue which describe your plans on HAL rework.

Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-trivial changes should take place with diverse discussions!

@jserv
Copy link
Member

jserv commented Jul 30, 2020

This issue should not exist unless we have plans.

@jserv jserv closed this Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Endpoint): Implement WP76xx platform
2 participants